Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): runtime building support no-cache option #1640

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Fixes #1636

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #1640 (8f662cb) into main (2d9b8b1) will increase coverage by 4.33%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main    #1640      +/-   ##
============================================
+ Coverage     80.34%   84.67%   +4.33%     
============================================
  Files           357       92     -265     
  Lines         19039    10474    -8565     
  Branches        953        0     -953     
============================================
- Hits          15297     8869    -6428     
+ Misses         3345     1605    -1740     
+ Partials        397        0     -397     
Flag Coverage Δ
controller ?
standalone 84.67% <83.33%> (-0.02%) ⬇️
unittests 84.67% <83.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/runtime/view.py 93.57% <ø> (ø)
client/starwhale/core/runtime/model.py 94.70% <80.00%> (+0.02%) ⬆️
client/starwhale/core/runtime/cli.py 82.85% <100.00%> (+0.12%) ⬆️
...va/ai/starwhale/mlops/domain/job/po/JobEntity.java
...whale/mlops/domain/job/step/status/StepStatus.java
.../java/ai/starwhale/mlops/api/SystemController.java
...rwhale/mlops/datastore/parquet/SwWriteSupport.java
...ai/starwhale/mlops/domain/job/step/StepHelper.java
...ai/starwhale/mlops/datastore/ColumnTypeObject.java
.../mlops/domain/dataset/upload/HotDatasetHolder.java
... and 259 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui requested a review from tianweidut December 20, 2022 13:38
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 586627e into star-whale:main Dec 21, 2022
@jialeicui jialeicui deleted the rt-build-no-cache branch December 21, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime build support --no-cache option
2 participants